Fix default values via reflection for LoggerInterface (PHP 8 only)

Using ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE

See #78

CHANGELOG.md

@@ -9,6 +9,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 ### Fixed 
 - Test failures on PHP 8.0.0alpha1
 - Compile failures with clang
+- Report proper default value in reflection for LoggerInterface - PHP 8 only ([GH-78](https://github.com/jbboehr/php-psr/issues/78))
 
 ## [1.0.0] - 2020-02-18
 

psr_log.h

@@ -18,50 +18,56 @@ extern PHP_PSR_API zend_class_entry * PsrLogLoggerAwareTrait_ce_ptr;
 
 extern PHP_MINIT_FUNCTION(psr_log);
 
+#if PHP_VERSION_ID < 80000
+#define PHP_PSR_CONTEXT_PARAM ZEND_ARG_ARRAY_INFO(0, context, 0)
+#else
+#define PHP_PSR_CONTEXT_PARAM ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, context, IS_ARRAY, 0, "[]")
+#endif
+
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, emergency, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, alert, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, critical, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, error, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, warning, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, notice, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, info, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, debug, 1)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerInterface, log, 2)
     ZEND_ARG_INFO(0, level)
     ZEND_ARG_INFO(0, message)
-    ZEND_ARG_ARRAY_INFO(0, context, 0)
+    PHP_PSR_CONTEXT_PARAM
 PHP_PSR_END_ARG_INFO()
 
 PHP_PSR_BEGIN_ARG_INFO(PsrLogLoggerAwareInterface, setLogger, 1)

tests/gh78_php7.phpt

@@ -0,0 +1,23 @@
+--TEST--
+Psr\Log\LoggerInterface - Invalid context default value (PHP 7)
+--SKIPIF--
+<?php
+include 'skip.inc';
+if (PHP_VERSION_ID >= 80000) {
+    print "skip Due to version incompatibility";
+}
+?>
+--FILE--
+<?php
+$reflectionMethod = new \ReflectionMethod(\Psr\Log\LoggerInterface::class, "emergency");
+$reflectionParameter = $reflectionMethod->getParameters()[1];
+var_dump($reflectionParameter->isOptional());
+var_dump($reflectionParameter->isDefaultValueAvailable());
+var_dump($reflectionParameter->getDefaultValue());
+--EXPECT--
+bool(true)
+bool(true)
+array(0) {
+}
+--XFAIL--
+PHP 7 internal functions cannot have default values reported via reflection

tests/gh78_php8.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Psr\Log\LoggerInterface - Invalid context default value (PHP 8)
+--SKIPIF--
+<?php
+include 'skip.inc';
+if (PHP_VERSION_ID < 80000) {
+    print "skip Due to version incompatibility";
+}
+?>
+--FILE--
+<?php
+$reflectionMethod = new \ReflectionMethod(\Psr\Log\LoggerInterface::class, "emergency");
+$reflectionParameter = $reflectionMethod->getParameters()[1];
+var_dump($reflectionParameter->isOptional());
+var_dump($reflectionParameter->isDefaultValueAvailable());
+var_dump($reflectionParameter->getDefaultValue());
+--EXPECT--
+bool(true)
+bool(true)
+array(0) {
+}