Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#92 - Fix PHP 8.1 compatibility and add 8.1 into CI workflows #93

Closed
wants to merge 7 commits into from
Closed

#92 - Fix PHP 8.1 compatibility and add 8.1 into CI workflows #93

wants to merge 7 commits into from

Conversation

Jeckerson
Copy link
Contributor

@Jeckerson Jeckerson commented Nov 28, 2021 •
edited

#92

@Jeckerson Jeckerson marked this pull request as ready for review November 28, 2021 17:36
sergeyklay
sergeyklay approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the patch

This was referenced Nov 28, 2021
Closed
Closed
@sergeyklay
Copy link
Contributor

@jbboehr Could you please take a look

@kaioken
Copy link

kaioken commented Dec 9, 2021

hi @sergeyklay any idea when this will get merge so phalcon can get to 8.1 😄

@sergeyklay
Copy link
Contributor

@kaioken Hi! No, I have no idea. I have no rights and we are wait for @jbboehr

@kaioken
Copy link

kaioken commented Dec 9, 2021

@sergeyklay thanks ;) for the update, let's wait for @jbboehr . Keep up the great work

@jbboehr jbboehr self-requested a review December 11, 2021 17:30
@coveralls
Copy link

coveralls commented Dec 11, 2021 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 5f7dfc6 on Jeckerson:master into 920e4dd on jbboehr:master.

@jbboehr jbboehr closed this in 61d6ac6 Dec 11, 2021
jbboehr pushed a commit that referenced this pull request Dec 11, 2021
@Jeckerson @jbboehr
PHP 8.1 compatibility
8d8b578 
* Bump version of `tukio` to `1.3.0`
* Bump version of `laminas/laminas-diactoros` to `2.8.0`
* Add 8.1 version into CI workflows
* Fix `StreamInterface::__toString()` compatibility with PHP 8.1

Closes #92
Closes #93
jbboehr pushed a commit that referenced this pull request Dec 11, 2021
@Jeckerson @jbboehr
PHP 8.1 compatibility
b52d62a 
* Bump version of `tukio` to `1.3.0`
* Bump version of `laminas/laminas-diactoros` to `2.8.0`
* Add 8.1 version into CI workflows
* Fix `StreamInterface::__toString()` compatibility with PHP 8.1

Closes #92
Closes #93
@jbboehr
Copy link
Owner

jbboehr commented Dec 11, 2021

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbboehr jbboehr jbboehr approved these changes

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jeckerson @sergeyklay @kaioken @coveralls @jbboehr