assignments:load returns type Response #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so no need to call the response? predicate on the page-result since it already has that type
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assignments:loadfunction return type isResponse, so no need to call theresponse?predicate on thepage-resultsince it already has that type.This change is related to the Typed Racket pull request racket/typed-racket#882, which fixes an unsoundness in opaque-type predicates. This change allows this code to typecheck after the unsoundness is fixed.
However, if
response?never returns never changes its result for the same argument value, then this PR makes it simpler, changes no behavior, and lets it typecheck in both versions of typed-racket.