Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing requires clauses #21

Closed
jbcoe opened this issue Sep 19, 2023 · 2 comments
Closed

Add missing requires clauses #21

jbcoe opened this issue Sep 19, 2023 · 2 comments
Assignees

Comments

@jbcoe
Copy link
Owner

jbcoe commented Sep 19, 2023

My minimal implementations don’t make any of the checks that they perhaps should. We’d get better compiler errors with the addition of concept checks. We need to be sure that incomplete types are still supported (like in indirect_value) though as that’s a useful use case (Pimpl).

Ideally we could check that the newly added requirements are doing the right thing in tests.

@jbcoe jbcoe assigned Twon and jbcoe and unassigned Twon Sep 19, 2023
@jbcoe
Copy link
Owner Author

jbcoe commented Sep 24, 2023

@Twon to review and close.

@jbcoe jbcoe assigned Twon and unassigned jbcoe Sep 24, 2023
@jbcoe jbcoe added the Priority label Sep 26, 2023
@jbcoe jbcoe added this to the Paper prepared for Kona mailing milestone Oct 12, 2023
@jbcoe jbcoe removed the Priority label Oct 12, 2023
@Twon Twon closed this as completed Oct 13, 2023
@Twon
Copy link
Collaborator

Twon commented Oct 13, 2023

Closed as I following a review of all requires statements I believe these are required and inline with expectations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants