Add comparisons and concept checks #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 94.98% 95.21% +0.22%
==========================================
Files 4 4
Lines 459 481 +22
==========================================
+ Hits 436 458 +22
Misses 23 23
☔ View full report in Codecov by Sentry. |
These changes ended up coupled as <=> needs concept checks. For CI, use AppleClang 14 and Xcode 14 to get concept support
jbcoe
force-pushed
the
dev-jbcoe-concepts-and-comparisons
branch
from
5c01f9e
to
bc79e81
Compare
Twon
approved these changes
Sep 23, 2023
jbcoe
added a commit
that referenced
this pull request
Sep 23, 2023
Added discussion of design and compromises. Note: Missing comparison and hash for indirect as their inclusion needs a PR (#29) to be merged.
Remove duplicated member function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Progresses #21