Discuss optional #55
Merged
Discuss optional #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 4 4
Lines 567 567
=======================================
Hits 546 546
Misses 21 21 ☔ View full report in Codecov by Sentry. |
Twon
reviewed
Sep 26, 2023
| Note: As the null state of `indirect` and `polymorphic` is not observable, and | ||
| access to a moved from object is erroneous, `std::optional` can be specialized | ||
| by implementers to exchange pointers on move construction and assignment. | ||
|
|
There was a problem hiding this comment.
Perhaps worth mentioning that if specialised then optional<indirect<T>> or optional<polymorphic<T>> would incur no performance penalties.
Also a reference on other languages doing the same for nullable types: https://borretti.me/article/type-systems-memory-safety#option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.