New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBIDE-23657 switch from PermSize to... #438
Conversation
-vmargs | ||
-Xms256m | ||
-Xmx1024m | ||
-XX:MaxMetaspaceSize=512m | ||
-XX:MetaspaceSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove it ? I doubt it is accepted by JVM if you don't specify a size
@@ -20,7 +20,7 @@ | |||
<stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.7"/> | |||
<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl en_AA"/> | |||
<stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/> | |||
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Xms128m -Xmx512m -XX:MaxMetaspaceSize=512m -d32"/> | |||
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Xms128m -Xmx512m -XX:MetaspaceSize -d32"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
…DK8); also bump MaxMetaspaceSize to 512m from 256m Signed-off-by: nickboldt <nboldt@redhat.com> JBIDE-23657 use MetaspaceSize with no max or min values Signed-off-by: nickboldt <nboldt@redhat.com> set -XX:MetaspaceSize=256m Signed-off-by: nickboldt <nboldt@redhat.com>
7dec16e
to
d57cc85
Compare
--launcher.defaultAction | ||
openFile</programArgs> | ||
<vmArgs>-Xms512m | ||
-Xmx1024m | ||
-Dosgi.framework.extensions=org.eclipse.wst.jsdt.nashorn.extension | ||
-Dosgi.instance.area.default=@user.home/workspace</vmArgs> | ||
<vmArgsMac>-XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts | ||
-Xdock:icon=../Resources/devstudio.icns -XX:MaxMetaspaceSize=512m -Xdock:name="Red Hat JBoss Developer Studio"</vmArgsMac> | ||
-Xdock:icon=../Resources/devstudio.icns -XX:MetaspaceSize -Xdock:name="Red Hat JBoss Developer Studio"</vmArgsMac> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
JBIDE-23657 switch from PermSize to MetaspaceSize (since we requite JDK8); also bump MaxMetaspaceSize to 512m from 256m
Signed-off-by: nickboldt nboldt@redhat.com