Fixed bug in node and browser platforms implementations of getDocumen…

…tFromUrl.
jbeard4 · Jul 9, 2012 · e48aeb7 · e48aeb7
1 parent cbb9df3
commit e48aeb7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 25 deletions.
diff --git a/lib/browser/platform.js b/lib/browser/platform.js
@@ -8,7 +8,7 @@ module.exports = {
     getDocumentFromUrl : function(url,cb){
         this.ajax.get(url,function(r){
             cb(null,r);
-        },url).error(function(e){
+        },"xml").error(function(e){
             cb(e);
         });
     },

diff --git a/lib/node/platform.js b/lib/node/platform.js
@@ -7,42 +7,35 @@ function parseDocumentFromString(str){
     return (new xmldom.DOMParser()).parseFromString(str);
 }
 
+function onModelCb(cb){
+    return function(err,s){
+        if(err){
+            cb(err);
+        }else{
+            try {
+                var doc = parseDocumentFromString(s);
+                cb(null,doc);
+            }catch(e){
+                cb(e);
+            }
+        }
+    };
+}
+
 module.exports = {
 
     pathSeparator : pathModule.join('x', 'x')[1],
 
     //used in parsing
     getDocumentFromUrl : function(url,cb){
-        get.httpGet(url,function(err,s){
-            if(err){
-                cb(err);
-            }else{
-                try {
-                    var doc = this.parseDocumentFromString(s);
-                    cb(null,doc);
-                }catch(e){
-                    cb(e);
-                }
-            }
-        });
+        get.httpGet(url,onModelCb(cb));
     },
 
     parseDocumentFromString : parseDocumentFromString,
 
     //TODO: the callback is duplicate code. move this out.
     getDocumentFromFilesystem : function(path,cb){
-        fs.readFile(path,'utf8',function(err,s){
-            if(err){
-                cb(err);
-            }else{
-                try{
-                    var doc = parseDocumentFromString(s);
-                    cb(null,doc);
-                }catch(e){
-                    cb(e);
-                }
-            }
-        });
+        fs.readFile(path,'utf8',onModelCb(cb));
     },
 
     getResourceFromUrl : get.getResource,