Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set MinReliableKeepPercent #36

Open
GoogleCodeExporter opened this issue Jul 1, 2015 · 1 comment
Open

Add possibility to set MinReliableKeepPercent #36

GoogleCodeExporter opened this issue Jul 1, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. try to detect the language of attached input file
2. see the output is "unknown"

What is the expected output? What do you see instead?
I would expect either 'perssian' or 'arabic'

What version of the product are you using? On what operating system?
rev195 on centos 7

Please provide any additional information below.

CLD2 returns "unknown" because the reliability is lower than 
kMinReliableKeepPercent (in compact_lang_det_impl.cc) :
static const int kMinReliableKeepPercent = 41;  // Remove lang if reli < this

Would adding an additional parameter to the DetectLanguageXXX(...) in order to 
set this threshold be acceptable ?

Regards

Original issue reported on code.google.com by William....@gmail.com on 11 Jun 2015 at 5:07

Attachments:

@GoogleCodeExporter
Copy link
Author

That's a good suggestion. I'd really like to see us consider an alternative 
scheme where we use the builder pattern to construct a settings/config object, 
so that we can keep the API as stable as possible while accommodating 
reasonable requests for behavioral changes like this.

Jason/Dick, what do you think?

Original comment by andrewha...@google.com on 11 Jun 2015 at 8:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant