Cache reload asynchronous #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cache is now not built when it is requested, but when something changed - Rebuild is done asynchronously, and only one at a time - This first iteration is a first hack, no tests nor any proper segmentation present.
- Dropped ProcessGroup and recreated MonitoredExecutor (test similar) - All users of ProcessGroup.spawn() could be converted to Runnable - Clarified thread separation of scan and completion in Loader - Final benefit: Easier testing for StepCandidateCacheLoader - added unit tests for StepCandidateCacheLoader
- Organized imports (removed unused ones) - Moved static helper to place of usage - Renamed variables and types for better meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache reload mechanism has been rebuilt to run asynchronously and update the editor upon completion. Queries for step candidates are always done against the last known cache.
Code changes:
This merge should handle #1 and #6.