Fix: Resolving steps of referenced jars #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted JBehaveProject.addStepCandidates() into dedicated MethodToStepCandidateReducer.
MethodToStepCandidateReducer does not know about project specific stuff any more, covered behind the listener. StepCandidate does not carry IAnnotation anymore, priority directly used
- covered annotation types Given,When,Then,Alias,Aliases
- specific unit test added - full qualified name is still assumed to be from JBehave if missing
- extracted method for pattern variant extraction (code duplication) - StepType default is fixed to be GIVEN - removed unnecessary null checks - fixed logging config (wrong package used for ErrorLevelConverter)
maurotalevi
added a commit
that referenced
this pull request
Feb 28, 2013
Fix: Resolving steps of referenced jars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code fixes #5, handling the case when steps are provided in jars from dependencies, where annotations are identified with the full qualified name.
Code changes in a gist:
Note: This merge also includes the code from merge request #8