Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getFeatureSet methods to ODGI and ODGIW #315

Merged
merged 1 commit into from
May 9, 2024
Merged

add getFeatureSet methods to ODGI and ODGIW #315

merged 1 commit into from
May 9, 2024

Conversation

jbellis
Copy link
Owner

@jbellis jbellis commented May 9, 2024

apply this to not relying on exceptions for SSP construction in Grid

(C* will use it too)

apply this to not relying on exceptions for SSP construction in Grid
@jbellis jbellis requested a review from jkni May 9, 2024 15:09
@jbellis jbellis self-assigned this May 9, 2024
@jbellis
Copy link
Owner Author

jbellis commented May 9, 2024

I removed the permissibleFeatures overload of approximateScoreFunctionFor, not completely sure what you had in mind there but istm we can apply the YAGNI principle for now

@jkni
Copy link
Collaborator

jkni commented May 9, 2024

Yes, I anticipated needing that overload on an earlier version of the patch, and I was wrong about needing it right away. Cleaning it up makes sense.

@jbellis jbellis merged commit 3e53eea into main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants