Implement optimized decoded square distance #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkni
commented
Sep 19, 2023
| @@ -128,8 +128,6 @@ static float dotProduct64(float[] v1, int v1offset, float[] v2, int v2offset, in | |||
| if (length == FloatVector.SPECIES_64.length()) | |||
| return dot64(v1, v1offset, v2, v2offset); | |||
|
|
|||
| assert length == 3; // or we should be calling dot 128 | |||
There was a problem hiding this comment.
note: this is removed because it's not quite right. You could be down this code path with a one-dimensional vector, which is valid everywhere else in the codebase
jkni
commented
Sep 19, 2023
| return diff.mul(diff).reduceLanes(VectorOperators.ADD); | ||
| } | ||
|
|
||
| static float squareDistance512(float[] v1, int offset1, float[] v2, int offset2) { |
There was a problem hiding this comment.
This should be squareDistancePreferred, will fix
jbellis
approved these changes
Sep 20, 2023
|
Pushed update to use VectorUtil.sum. Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also implements the necessary SimdOps backing methods, mirroring the dotProduct implementation.
As a side benefit, PQ encoding is about twice as fast.