Fragment cache #94
Merged
Fragment cache #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not worrying about the case where the graph is too small to benefit from caching, b/c C* already tries to detect tiny graphs and do a brute force comparison anyway. Can revisit later if necessary. |
jkni
reviewed
Sep 22, 2023
| case EUCLIDEAN: | ||
| cache[i][j] = VectorUtil.squareDistance(centroidSubvector, 0, centeredQuery, offset, centroidSubvector.length); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
cosine too expensive to be worth precomputing?
jvector-base/src/main/java/io/github/jbellis/jvector/pq/CompressedDecoder.java
Outdated
Show resolved
Hide resolved
jbellis
force-pushed
the
fragment-cache
branch
from
444096f
to
1f78f1d
Compare
jbellis
force-pushed
the
fragment-cache
branch
from
1f78f1d
to
79fc0e5
Compare
jkni
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.