Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBERET-369] Create a BOM for using JBeret in Java SE standalone envi… #164

Merged
merged 1 commit into from Sep 14, 2021
Merged

[JBERET-369] Create a BOM for using JBeret in Java SE standalone envi… #164

merged 1 commit into from Sep 14, 2021

Conversation

moulalis
Copy link
Contributor

@moulalis moulalis mentioned this pull request Aug 30, 2021
Merged
chengfang
chengfang reviewed Sep 9, 2021
View reviewed changes
jberet-se-bom/pom.xml Outdated
<version.org.jberet>1.4.4.Final</version.org.jberet>
<version.org.jberet.support>1.3.4.Final</version.org.jberet.support>
<version.org.spec.javax.batch>2.0.0.Final</version.org.spec.javax.batch>
<version.org.spec.javax.transaction>2.0.0.CR1</version.org.spec.javax.transaction>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.spec.javax... seems odd. Can you use the same property name as in jberet-parent, such as

version.org.jboss.spec.javax.batch.jboss-batch-api_1.0_spec

version.org.jboss.spec.javax.transaction.jboss-transaction-api_1.2_spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @chengfang I've updated the changes as per master PR, please review it.
Thanks.

@moulalis moulalis force-pushed the JBERET-369_1.4.x branch 3 times, most recently from 4127c74 to d221a90 Compare September 13, 2021 13:12
chengfang
chengfang reviewed Sep 13, 2021
View reviewed changes
jberet-se-bom/pom.xml Outdated
<groupId>org.codehaus.woodstox</groupId>
<artifactId>stax2-api</artifactId>
<version>${version.org.codehaus.woodstox.stax2-api}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aalto-xml and stax2-api should not be necessary. They are optional if users want to use them instead of the default JDK parser. For most users, these 2 dependencies are not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengfang changes modified. Thanks.

chengfang
chengfang reviewed Sep 13, 2021
View reviewed changes
pom.xml Outdated

<!-- Used in SE bom -->
<version.org.codehaus.woodstox.woodstox-core-asl>4.4.1</version.org.codehaus.woodstox.woodstox-core-asl>
<version.org.apache.qpid>0.10.0</version.org.apache.qpid>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, these 2 props are not used by most users and I think should not be in BOM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengfang changes modified. Thanks.

@chengfang chengfang merged commit dc9eede into jberet:1.4.x Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengfang chengfang chengfang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moulalis @chengfang