Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass custom hadolint version to action #86

Closed
jbergstroem opened this issue Sep 20, 2022 · 0 comments · Fixed by #87
Closed

Pass custom hadolint version to action #86

jbergstroem opened this issue Sep 20, 2022 · 0 comments · Fixed by #87
Labels
area: ci This is related to continuous integration type: feature Request to add new functionality

Comments

@jbergstroem
Copy link
Owner

Like many other github actions, this repo should also support passing a custom version of the binary for use. This would be implemented in the action itself, so testing needs to be consiered properly (currently, testing is done via a second repository triggered while landing to the main branch).
@jbergstroem jbergstroem added area: ci This is related to continuous integration type: feature Request to add new functionality labels Sep 20, 2022
jbergstroem added a commit that referenced this issue Sep 20, 2022
@jbergstroem
feat: support passing custom version
e81bb95 
Allow users to pin / pass a specific verison of hadolint.

Fixes: #86
@jbergstroem jbergstroem mentioned this issue Sep 20, 2022
Merged
jbergstroem added a commit that referenced this issue Sep 20, 2022
@jbergstroem
feat: support passing custom version
26d5a8a 
Allow users to pin / pass a specific verison of hadolint.

Fixes: #86
jbergstroem added a commit that referenced this issue Sep 21, 2022
@jbergstroem
feat: refactor hadolint version support
afa5da9 
- Allow users to pass a specific version of hadolint to action
- Move current hadolint version assignment to action
- Add e2e test to verify functionality
- Fix a bug where `hadolint_version` and `hadolint_output` weren't assigned

Allow users to pin / pass a specific verison of hadolint.

Fixes: #86
jbergstroem added a commit that referenced this issue Sep 21, 2022
@jbergstroem
feat: refactor hadolint version support
bc8b002 
- Allow users to pass a specific version of hadolint to action
- Move current hadolint version assignment to action
- Add e2e test to verify functionality
- Fix a bug where `hadolint_version` and `hadolint_output` weren't assigned

Fixes: #86
jbergstroem added a commit that referenced this issue Sep 21, 2022
@jbergstroem
feat: refactor hadolint version support
63d8694 
- Allow users to pass a specific version of hadolint to action
- Move current hadolint version assignment to action
- Add e2e test to verify functionality
- Fix a bug where `hadolint_version` and `hadolint_output` weren't assigned

Fixes: #86
@jbergstroem jbergstroem mentioned this issue Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ci This is related to continuous integration type: feature Request to add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor hadolint version support jbergstroem/hadolint-gh-action
1 participant
@jbergstroem