Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sortServer does not disable internal sorting #775

Closed
5 tasks done
elben10 opened this issue Feb 21, 2021 · 2 comments
Closed
5 tasks done

sortServer does not disable internal sorting #775

elben10 opened this issue Feb 21, 2021 · 2 comments
Assignees
@jbetancur
Labels
bug Something isn't working next The next version (beta)
Projects
RDT Next 7
Milestone
RDT Next

Comments

@elben10
Copy link

elben10 commented Feb 21, 2021 •
edited

Issue Check list

  • Read the README
  • You are using React 16.8.0+
  • You installed styled-components
  • Agree to the Code of Conduct
  • Include relevant code or preferably a code sandbox

Describe the bug

Internal sorting is not disabled when using sortServer. It seems that the internal sorting was disabled in version 6, but in version 7 internal sorting is not disabled when receiving sortServer

To Reproduce

Steps to reproduce the behavior:

  1. Working example version 6.11.6
  2. Non Working example version 7.0.0-alpha-5

Expected behavior

Internal sorting is disabled when receiving sortServer

Code Sandbox, Screenshots, or Relevant Code

Two code sandboxes is provided in the To Reproduce section

Versions (please complete the following information)

  • React: 16.13.1
  • Styled Components: 5.1.1
  • OS: iOS
  • Browser: Chrome

Additional context

No additional context
@elben10 elben10 changed the title Internal sorting is not disabled using sortServer sortServer does not disables internal sorting Feb 21, 2021
@elben10 elben10 changed the title sortServer does not disables internal sorting sortServer does not disable internal sorting Feb 21, 2021
@jbetancur jbetancur self-assigned this Feb 21, 2021
@jbetancur jbetancur added the bug Something isn't working label Feb 21, 2021
@jbetancur jbetancur added this to To do in RDT Next 7 via automation Feb 21, 2021
@jbetancur jbetancur added this to the RDT Next milestone Feb 21, 2021
@jbetancur jbetancur added the next The next version (beta) label Feb 21, 2021
@jbetancur
Copy link
Owner

Nice catch and thank you for providing details. I've added this as a bug to the next branch and will have a fix in alpha 6

@jbetancur jbetancur moved this from To do to In progress in RDT Next 7 Feb 22, 2021
@jbetancur jbetancur mentioned this issue Feb 22, 2021
Merged
@jbetancur
Copy link
Owner

Fixed in #776

RDT Next 7 automation moved this from In progress to Done Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbetancur jbetancur

Labels
bug Something isn't working next The next version (beta)
Projects
No open projects
RDT Next 7
  
Done
Milestone
RDT Next
Development

No branches or pull requests
2 participants
@jbetancur @elben10