Fixed typo by replacing Selected to onSelectedRowsChange in README.md
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t as binary so git no longer shows proper diffs (since it doesn't show diffs for binary files). I think this was intended for .gitignore (not sure that's the right format though). Fixed minor issue in README.md for how to access selected rows.
Codecov Report
@@ Coverage Diff @@
## next #817 +/- ##
=======================================
Coverage 26.08% 26.08%
=======================================
Files 42 42
Lines 897 897
Branches 328 328
=======================================
Hits 234 234
Misses 659 659
Partials 4 4 Continue to review full report at Codecov.
|
|
NICE catch! |
|
note the build is failing due to a TS issue I am working on, so we can merge this in. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
onSelectedRowsChangeis the correct property to use to access the selected rows (rather thanSelected).Also, I removed the
* binaryin .gitattributes since it was preventing me from seeing text file diffs. I think the* binaryline was intended for .gitignore. When used in .gitattributes, it means all files get checked out as type binary and git doesn't show diffs for binary files.