Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept reader parameters during assembly resolving #45

Closed
dcecile opened this issue Nov 22, 2010 · 2 comments
Closed

Accept reader parameters during assembly resolving #45

dcecile opened this issue Nov 22, 2010 · 2 comments
Labels
1.0 enhancement

Comments

@dcecile
Copy link

dcecile commented Nov 22, 2010

For the use case of disassembling with symbol info while using an assembly resolver, a new overload to IAssemblyResolver.Resolve could be provided. The workaround is calling MethodDefinition.ReadSymbols().

Currently, in the BaseAssemblyResolver class (line 95), the reader parameters are hardcoded.

return ModuleDefinition.ReadModule (file, new ReaderParameters { AssemblyResolver = this}).Assembly;
@jbevain
Copy link
Owner

jbevain commented Nov 24, 2010

This makes sense. I'll see about adding that before 1.0. Thanks.

@jbevain
Copy link
Owner

jbevain commented Nov 24, 2010

Fixed in master.

sbomer pushed a commit to sbomer/cecil that referenced this issue Dec 21, 2022
@tlakollo
Add Mono.Cecil.Pdb as a package otherwise NativePdb reading will fail…
0b64f74 
… in linker (jbevain#45)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbevain @dcecile