Compact MetadataSystem dicts after assembly load #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not 100% sure about this one, but my assumption was that: "when using the ImmediateModuleReader, the metadata system caches should all be empty (all resolved) after load." - If that holds true, then this change works, and makes sure that the (fairly large) dicts gets compacted (by GC'ing them).
| if (PInvokes != null) PInvokes.Clear (); | ||
| if (GenericParameters != null) GenericParameters.Clear (); | ||
| if (GenericConstraints != null) GenericConstraints.Clear (); | ||
| if (NestedTypes != null) NestedTypes = new Dictionary<uint, uint[]> (); |
There was a problem hiding this comment.
In that case you should pass a zero capacity to the dictionary.
There was a problem hiding this comment.
That's already the default capacity AFAICT, but I can force it if you prefer.
|
Fixed in f2097e0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"when using the ImmediateModuleReader, the metadata system
caches should all be empty (all resolved) after load."
(but I'm not sure that's correct)
the (fairly large) dicts gets compacted (by GC'ing them).