-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Standard 2.0 #16
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
force-pushed
the
netstandard2.0
branch
2 times, most recently
from
April 13, 2017 00:06
62e385e
to
64d0d80
Compare
Looks like with netstandard2.0 it's fully compatible! |
@jbogard how's Sydney? I'll update the PR with the RTM version shortly. |
Done |
@jbevain lgtm! |
Was this support added? |
hazzik
force-pushed
the
netstandard2.0
branch
2 times, most recently
from
April 20, 2018 23:37
2aae089
to
44a5c91
Compare
- Fix target framework - Add target dll - Add NUnit package references
No :( |
@jbevain Can we get this merged please? |
as above |
Thanks, I've pushed support for .NET SDK style projects and .NET Standard 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15