Sanitizing/Removing Iframe attributes properly #126
Comments
|
Hello! Do you have any news on this?
Amp version: https://rolhdz.net/detras-de-las-canciones-erika-ender/amp/ |
jbhannah
added a commit
that referenced
this issue
Feb 26, 2020
jbhannah
added a commit
that referenced
this issue
Feb 26, 2020
Fix sanitization of the allowfullscreen, allowtransparency, frameborder, and scrolling properties on iframe elements Fixes #126
jbhannah
added a commit
that referenced
this issue
Feb 26, 2020
Fix sanitization of the allowfullscreen, allowtransparency, frameborder, and scrolling properties on iframe elements Fixes #126
|
@pankajpatel @rolxhdz I've just pushed version 0.6.1, try updating and see if that fixes your issues. |
|
The |
|
@jbhannah - I'm still facing the same issue as seen in the attached screenshot. How do I fix it? I'm running Ghost 3.37.1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is coming form TryGhost/Ghost/issues/10796
As we can see from here: https://github.com/ampproject/amphtml/blob/master/extensions/amp-iframe/validator-amp-iframe.protoascii
The iframe attribute needs proper sanitization as some attributes accept no value but their presence and some attrs allow values from [
0,1]scrolling: value as 0 or 1frameborder: value as 0 or 1allowtransparency: presence and no valueallowfullscreen: presence and no valueThe text was updated successfully, but these errors were encountered: