Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treemap update #327

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Treemap update #327

merged 2 commits into from
Aug 23, 2017

Conversation

alexpghayes
Copy link
Contributor

This pull request is to address the following issues in the Highcharter function hctreemap:

I've created a markdown walkthrough dev/treemap2.Rmd documenting a new function hctreemap2 that I believe fixes these. Sorry this has taken me so long.

@jbkunst
Copy link
Owner

jbkunst commented Jun 19, 2017

Hi @alexpghayes

I'm really happy to see this :)! I will take 1 or 2 days to see the changes, and see how the functions works (I'm new to rlang) and see other details.

Thank you very much! With this it's probably make a new release soon!

Best,

@jbkunst
Copy link
Owner

jbkunst commented Jun 19, 2017

And don't say sorry 😅 !

@alexpghayes
Copy link
Contributor Author

alexpghayes commented Jun 20, 2017

The first half of this blog post covers all of the new dplyr NSE I used. I'm happy to comment the code or rewrite any sections for clarity. Probably the most useful thing to do to understand the function is to print out treemap_df after it's generated.

@jbkunst jbkunst merged commit f5198d9 into jbkunst:master Aug 23, 2017
@jbkunst
Copy link
Owner

jbkunst commented Aug 23, 2017

Hi @alexpghayes !!

I will take 1 or 2 days to see the changes,

The longest days on the entire history! So sorry! Thanks to you I will start the new release! I'll add you to the contributors in the DESCRIPTION if you don't mind

@jbkunst
Copy link
Owner

jbkunst commented Aug 23, 2017

If you create and id field, why is a problem have same labels across the grouping vars?

@alexpghayes
Copy link
Contributor Author

If the top level of the treemap has categories in {A, B} and second level has categories in {B, C}, for cells on a third level of the treemap a parent id of B1_B2 is ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants