Add tidyeval to `hcaes` and `mutate_mapping` #423

cnolanminich · 2018-04-05T13:43:12Z

Fixes #420

Updated primarily based on this ggplot2 commit that used rlang in the definition of aes().

Tested against the examples with ggplot2 2.2.1.9000’, and ran a couple of our apps that use both ggplot2 and highcharter

same strategy as Hadley's here: tidyverse/ggplot2@d697622

jbkunst · 2018-04-11T15:20:10Z

Hey @cnolanminich ,

This THANK YOU is not enough to express all my gratitude. I will test to merge this PR.

Hope @PaulC91 @peeyooshc @tungmilan can test after the merge.

Thanks again and give me your name/email if you want to be added to the DESCRIPTION file as contributor.

cnolanminich · 2018-04-11T15:38:46Z

@jbkunst thank you for this excellent package! I added my name to the DESCRIPTION, ran devtools::check() to make sure everything was formatted properly, and while doing so, noticed two functions from rlang that I had previously neglected to add to the NAMESPACE

tungttnguyen · 2018-04-12T04:55:56Z

Okay I've finished testing with both CRAN & dev versions of ggplot2 and @cnolanminich 's changes worked perfectly with new tidyeval and old examples posted by @jbkunst

I think it would be a good idea to include at least one working example with this PR either in the NEWS.md or somewhere else

Here is an example taken from the issue that I opened few weeks ago

library(tidyverse)
library(lubridate)
library(highcharter)
library(nycflights13)

flights_2 <- flights %>% 
  mutate(departure_month = ymd(str_c(year, month, "01", sep = "-"))) %>% 
  group_by(departure_month) %>% 
  summarize(arrival_delay = mean(arr_delay, na.rm = TRUE))
flights_2

hchart_func <- function(df, x, y) {
  x <- enexpr(x)
  y <- enexpr(y)
  hchart(df, 
         type = "line",
         hcaes(!!x, !!y),
         name = "Average Arrival Delay"
  )
}

hchart_func(df = flights_2, x = departure_month, y = arrival_delay)

tungttnguyen · 2018-04-12T05:04:04Z

Another (simpler) example:

x <- "displ"
y <- "cyl"

x <- rlang::sym(x)
y <- rlang::sym(y)

hchart(mpg, "point", hcaes(UQ(x), UQ(y)))

tungttnguyen · 2018-04-12T05:06:45Z

Testing old examples:


library("igraph")
N <- 40

net <- sample_gnp(N, p = 2/N)
wc <- cluster_walktrap(net)

V(net)$label <- seq(N)
V(net)$name <- paste("I'm #", seq(N))
V(net)$page_rank <- round(page.rank(net)$vector, 2)
V(net)$betweenness <- round(betweenness(net), 2)
V(net)$degree <- degree(net)
V(net)$size <- V(net)$degree
V(net)$comm <- membership(wc)
V(net)$color <- colorize(membership(wc))

hchart(net, layout = layout_with_fr)

x <- stl(log(AirPassengers), "per")
hchart(x)

data(mpg, diamonds, package = "ggplot2")

hchart(mpg, "point", hcaes(displ, hwy, group = drv), regression = TRUE) %>% 
  hc_colors(c("#d35400", "#2980b9", "#2ecc71")) %>% 
  hc_add_dependency("plugins/highcharts-regression.js")

Session Info:

Session info -------------------------------------------------------------------
 version  R version 3.4.4 (2018-03-15)
 system   x86_64, mingw32             
 ui       RStudio (1.1.444)        

Packages -----------------------------------------------------------------------
 package      * version    date       source                                   
 assertthat     0.2.0      2017-04-11 CRAN (R 3.4.4)                           
 base         * 3.4.4      2018-03-15 local                                    
 bindr          0.1.1      2018-03-13 CRAN (R 3.4.4)                           
 bindrcpp     * 0.2.2      2018-03-29 CRAN (R 3.4.4)                           
 broom          0.4.4      2018-03-29 CRAN (R 3.4.4)                           
 cellranger     1.1.0      2016-07-27 CRAN (R 3.4.4)                           
 cli            1.0.0      2017-11-05 CRAN (R 3.4.4)                           
 colorspace     1.3-2      2016-12-14 CRAN (R 3.4.4)                           
 compiler       3.4.4      2018-03-15 local                                    
 cowplot        0.9.2.9900 2018-04-07 Github (wilkelab/cowplot@bb819a1)        
 crayon         1.3.4      2017-09-16 CRAN (R 3.4.4)                           
 curl           3.2        2018-03-28 CRAN (R 3.4.4)                           
 data.table     1.10.4-3   2017-10-27 CRAN (R 3.4.4)                           
 datasets     * 3.4.4      2018-03-15 local                                    
 devtools       1.13.5     2018-02-18 CRAN (R 3.4.3)                           
 digest         0.6.15     2018-01-28 CRAN (R 3.4.3)                           
 dplyr        * 0.7.4.9004 2018-04-12 Github (tidyverse/dplyr@30953f1)         
 forcats      * 0.3.0      2018-02-19 CRAN (R 3.4.4)                           
 foreign        0.8-69     2017-06-22 CRAN (R 3.4.4)                           
 fortunes       1.5-4      2016-12-29 CRAN (R 3.4.1)                           
 GGally         1.3.2      2017-08-02 CRAN (R 3.4.4)                           
 ggplot2      * 2.2.1.9000 2018-04-12 Github (tidyverse/ggplot2@3c9c504)       
 glue           1.2.0      2017-10-29 CRAN (R 3.4.4)                           
 graphics     * 3.4.4      2018-03-15 local                                    
 grDevices    * 3.4.4      2018-03-15 local                                    
 grid           3.4.4      2018-03-15 local                                    
 gtable         0.2.0      2016-02-26 CRAN (R 3.4.4)                           
 haven          1.1.1      2018-01-18 CRAN (R 3.4.4)                           
 highcharter  * 0.6.0      2018-04-12 Github (cnolanminich/highcharter@85a0d56)
 hms            0.4.2      2018-04-07 Github (tidyverse/hms@c0cfc01)           
 htmltools      0.3.6      2017-04-28 CRAN (R 3.4.4)                           
 htmlwidgets    1.0        2018-01-20 CRAN (R 3.4.4)                           
 httr           1.3.1      2017-08-20 CRAN (R 3.4.4)                           
 igraph       * 1.2.1      2018-03-10 CRAN (R 3.4.4)                           
 jsonlite       1.5        2017-06-01 CRAN (R 3.4.4)                           
 labeling       0.3        2014-08-23 CRAN (R 3.4.1)                           
 lattice        0.20-35    2017-03-25 CRAN (R 3.4.4)                           
 lazyeval       0.2.1      2017-10-29 CRAN (R 3.4.4)                           
 lubridate    * 1.7.2      2018-02-06 CRAN (R 3.4.3)                           
 magrittr       1.5        2014-11-22 CRAN (R 3.4.4)                           
 memoise        1.1.0      2017-04-21 CRAN (R 3.4.4)                           
 methods      * 3.4.4      2018-03-15 local                                    
 mnormt         1.5-5      2016-10-15 CRAN (R 3.4.1)                           
 modelr         0.1.1      2017-07-24 CRAN (R 3.4.4)                           
 munsell        0.4.3      2016-02-13 CRAN (R 3.4.4)                           
 nlme           3.1-137    2018-04-07 CRAN (R 3.4.4)                           
 nycflights13 * 0.2.2      2017-01-27 CRAN (R 3.4.4)                           
 parallel       3.4.4      2018-03-15 local                                    
 pillar         1.2.1      2018-02-27 CRAN (R 3.4.4)                           
 pkgconfig      2.0.1      2017-03-21 CRAN (R 3.4.4)                           
 plyr           1.8.4      2016-06-08 CRAN (R 3.4.4)                           
 psych          1.8.3.3    2018-03-30 CRAN (R 3.4.4)                           
 purrr        * 0.2.4      2017-10-18 CRAN (R 3.4.4)                           
 quantmod       0.4-12     2017-12-10 CRAN (R 3.4.4)                           
 R6             2.2.2      2017-06-17 CRAN (R 3.4.4)                           
 raster         2.6-7      2017-11-13 CRAN (R 3.4.4)                           
 RColorBrewer   1.1-2      2014-12-07 CRAN (R 3.4.1)                           
 Rcpp           0.12.16    2018-03-13 CRAN (R 3.4.4)                           
 readr        * 1.2.0      2018-04-07 Github (tidyverse/readr@23eb46d)         
 readxl         1.0.0.9000 2018-04-06 Github (tidyverse/readxl@eeeebf8)        
 reshape        0.8.7      2017-08-06 CRAN (R 3.4.4)                           
 reshape2       1.4.3      2017-12-11 CRAN (R 3.4.4)                           
 rlang        * 0.2.0.9001 2018-04-12 Github (r-lib/rlang@70d2d40)             
 rlist          0.4.6.1    2016-04-04 CRAN (R 3.4.4)                           
 rstudioapi     0.7        2017-09-07 CRAN (R 3.4.4)                           
 rvest          0.3.2      2016-06-17 CRAN (R 3.4.3)                           
 scales         0.5.0.9000 2018-04-12 Github (hadley/scales@d767915)           
 sp             1.2-7      2018-01-19 CRAN (R 3.4.3)                           
 stats        * 3.4.4      2018-03-15 local                                    
 stringi        1.1.7      2018-03-12 CRAN (R 3.4.4)                           
 stringr      * 1.3.0      2018-02-19 CRAN (R 3.4.4)                           
 tibble       * 1.4.2      2018-01-22 CRAN (R 3.4.4)                           
 tidyr        * 0.8.0      2018-01-29 CRAN (R 3.4.4)                           
 tidyselect     0.2.4      2018-02-26 CRAN (R 3.4.4)                           
 tidyverse    * 1.2.1      2017-11-14 CRAN (R 3.4.4)                           
 tools          3.4.4      2018-03-15 local                                    
 TTR            0.23-3     2018-01-24 CRAN (R 3.4.3)                           
 utf8           1.1.3      2018-01-03 CRAN (R 3.4.4)                           
 utils        * 3.4.4      2018-03-15 local                                    
 whisker        0.3-2      2013-04-28 CRAN (R 3.4.4)                           
 withr          2.1.2      2018-03-15 CRAN (R 3.4.4)                           
 xml2           1.2.0      2018-01-24 CRAN (R 3.4.3)                           
 xts            0.10-2     2018-03-14 CRAN (R 3.4.4)                           
 yaml           2.1.18     2018-03-08 CRAN (R 3.4.4)                           
 zoo            1.8-1      2018-01-08 CRAN (R 3.4.4)

tungttnguyen · 2018-04-12T05:18:24Z

R/api-hc-hc_add_series.R


  if(drop)
-    data <- select_(data, .dots = names(mapping))
+    newv <- quos(names(mapping))


Can you reuse newv which is already defined in line # 409?

@tungmilan 👍 good call --

I realized while doing this that it would be better to use rlang::syms() vs rlang::quos(), as in the following in muate_mapping. If using rlang::quos() and re-using newv I get the following error: Error: newvmust resolve to integer column positions, not a list. Anyway, I think syms() makes more sense anyway.
If you agree, I can push the version using syms() and we can test again :)

mutate_mapping <- function(data, mapping, drop = FALSE) { stopifnot(is.data.frame(data), inherits(mapping, "hcaes"), inherits(drop, "logical")) # https://stackoverflow.com/questions/45359917/dplyr-0-7-equivalent-for-deprecated-mutate # https://www.johnmackintosh.com/2018-02-19-theory-free-tidyeval/ tran <- as.character(mapping) newv <- names(mapping) list_names <- setNames(tran, newv) %>% lapply(rlang::parse_quosure) data <- dplyr::mutate(data, !!! list_names) # Reserverd highcharts names (#241) if(has_name(data, "series")) #old <- "seriess" #new <- "series" data <- dplyr::rename(data, "seriess" = "series") if(drop) newv <- rlang::syms(newv) data <- dplyr::select(data, !!! newv) data }

I like that. Let me know when it's ready for testing again :)

cnolanminich · 2018-04-12T14:55:19Z

@tungmilan made the switch you suggested -- let me know how your tests go!

tungttnguyen · 2018-04-12T14:58:59Z

@cnolanminich : great! will do it later today

tungttnguyen · 2018-04-12T16:29:03Z

@cnolanminich : I've finished the testing. Everything looks good. I think it's ready :)

cnolanminich · 2018-04-17T00:36:59Z

@jbkunst let me know if there's anything else you need on my end for this to be merged

jbkunst · 2018-04-17T13:12:22Z

Ok! @cnolanminich @tungmilan let's merge guys.

Thanks you all!

PaulC91 · 2018-04-17T13:17:54Z

great job guys. much appreciated! @cnolanminich @tungmilan @jbkunst

@cnolanminich

Add tidyeval to `hcaes` and `mutate_mapping`, thnks to @cnolanminich

Christian and others added 2 commits April 3, 2018 16:36

add tidyeval to muate_mapping

95a7bcd

Add quasiquotation support to aes

106b942

same strategy as Hadley's here: tidyverse/ggplot2@d697622

Christian added 2 commits April 11, 2018 11:32

add Christian to DESCRIPTION

334b488

add rlang imports

85a0d56

tungttnguyen reviewed Apr 12, 2018

View reviewed changes

change quos to syms in mutate_mapping

e6d681f

jbkunst merged commit ccfdbe5 into jbkunst:master Apr 17, 2018

tungttnguyen mentioned this pull request Jul 6, 2018

Error in mutate_impl(.data, dots) : Column x is of unsupported type quoted call #420

Closed

ari-nz pushed a commit to ari-nz/highcharter that referenced this pull request May 23, 2020

Merge pull request jbkunst#423 from cnolanminich/master

0543779

Add tidyeval to `hcaes` and `mutate_mapping`, thnks to @cnolanminich

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tidyeval to `hcaes` and `mutate_mapping` #423

Add tidyeval to `hcaes` and `mutate_mapping` #423

cnolanminich commented Apr 5, 2018

jbkunst commented Apr 11, 2018 •

edited

cnolanminich commented Apr 11, 2018

tungttnguyen commented Apr 12, 2018 •

edited

tungttnguyen commented Apr 12, 2018 •

edited

tungttnguyen commented Apr 12, 2018 •

edited

tungttnguyen Apr 12, 2018

cnolanminich Apr 12, 2018

tungttnguyen Apr 12, 2018

cnolanminich commented Apr 12, 2018

tungttnguyen commented Apr 12, 2018

tungttnguyen commented Apr 12, 2018

cnolanminich commented Apr 17, 2018

jbkunst commented Apr 17, 2018

PaulC91 commented Apr 17, 2018

Add tidyeval to hcaes and mutate_mapping #423

Add tidyeval to hcaes and mutate_mapping #423

Conversation

cnolanminich commented Apr 5, 2018

jbkunst commented Apr 11, 2018 • edited

cnolanminich commented Apr 11, 2018

tungttnguyen commented Apr 12, 2018 • edited

tungttnguyen commented Apr 12, 2018 • edited

tungttnguyen commented Apr 12, 2018 • edited

tungttnguyen Apr 12, 2018

Choose a reason for hiding this comment

cnolanminich Apr 12, 2018

Choose a reason for hiding this comment

tungttnguyen Apr 12, 2018

Choose a reason for hiding this comment

cnolanminich commented Apr 12, 2018

tungttnguyen commented Apr 12, 2018

tungttnguyen commented Apr 12, 2018

cnolanminich commented Apr 17, 2018

jbkunst commented Apr 17, 2018

PaulC91 commented Apr 17, 2018

Add tidyeval to `hcaes` and `mutate_mapping` #423

Add tidyeval to `hcaes` and `mutate_mapping` #423

jbkunst commented Apr 11, 2018 •

edited

tungttnguyen commented Apr 12, 2018 •

edited

tungttnguyen commented Apr 12, 2018 •

edited

tungttnguyen commented Apr 12, 2018 •

edited