Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySAM problems with Python 3.8 + OS X #58

Closed
bede opened this issue Dec 2, 2019 · 5 comments
Closed

PySAM problems with Python 3.8 + OS X #58

bede opened this issue Dec 2, 2019 · 5 comments

Comments

@bede
Copy link

bede commented Dec 2, 2019

pip install alignparse fails for me inside a clean MacOS 10.14 + Python 3.8 environment created with conda due to a PySAM build issue. Using Python 3.7 or else installing pysam with conda in 3.8 works just fine.

Quite likely to be a Mac only issue that will be resolved in a future pysam update, but you could consider creating an evironment.yml to allow conda to users to install prebuilt dependencies via
conda env create -f environment.yml

Edit: conda would also allow managed installation of minimap2

@khdcrawford
Copy link
Collaborator

We have an environment.yml file in the main repo that I think should work for this. It specifies using Python 3.6 to avoid the issues with pysam. I just tested creating the environment locally on my machine and it seemed to work, but let me know if you run into issues! Thanks for your quick review, @bede!

@jbloom
Copy link
Member

jbloom commented Dec 4, 2019

@khdusenbury: Maybe we should also update the docs on installation to say that alignparse requires Python 3.6 or higher, and is currently tested on Python 3.6 and 3.7. It should work on 3.8 (except for the pysam issues which are outside our purview), but right now the Travis tests only run for 3.6 and 3.7.

@khdcrawford
Copy link
Collaborator

Implemented in PR #59.

@afrubin
Copy link
Contributor

afrubin commented Dec 8, 2019

@khdusenbury: Maybe we should also update the docs on installation to say that alignparse requires Python 3.6 or higher, and is currently tested on Python 3.6 and 3.7. It should work on 3.8 (except for the pysam issues which are outside our purview), but right now the Travis tests only run for 3.6 and 3.7.

Just wanted to point out that the README still has the old language ("requires Python 3.6 or 3.7").

@jbloom jbloom reopened this Dec 9, 2019
jbloom added a commit that referenced this issue Dec 9, 2019
In issue 58, @afrubin pointed out that the README did
not accurately described the Python version reqs (see
#58 (comment)).

The descriptions are correct in the installation docs. Rather
than updating the README in a way that keeps the information
in two places (and so will be prone to becoming wrong again),
I've simply streamlined the README to point to the installation
docs for details.
@jbloom
Copy link
Member

jbloom commented Dec 9, 2019

@afrubin: Good point. I've created a pull request for @khdusenbury to review that should address this issue (pull request #60).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants