-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Targets.parse_alignment
#20
Commits on Aug 12, 2019
-
Set up
Targets
to havefeature_parse_specs
This changes how features are specified to `Targets`, in a way that will mesh with `parse_alignments`.
Configuration menu - View commit details
-
Copy full SHA for 0c368b8 - Browse repository at this point
Copy the full SHA 0c368b8View commit details
Commits on Aug 13, 2019
-
update
feature_parse_specs
, add to RecA exampleSlightly altered specs for `feature_parse_specs` as described in docs for `Targets`. This allows the `feature_parse_specs` to also specifying filtering criteria. Then updated code to better check for correct targets / features in `feature_parse_specs` in `Targets.__init__`, and removed redundant code from `Targets.parse_alignment_cs`. Finally, added the feature parse specs YAML file for the RecA example and updated the corresponding Jupyter notebook.
1Configuration menu - View commit details
-
Copy full SHA for 783438d - Browse repository at this point
Copy the full SHA 783438dView commit details -
Targets
feature_parse_specs
as YAML or dictNow can pass and get `feature_parse_specs` as a YAML file or a dict.
Configuration menu - View commit details
-
Copy full SHA for f686f57 - Browse repository at this point
Copy the full SHA f686f57View commit details
Commits on Aug 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3262f1b - Browse repository at this point
Copy the full SHA 3262f1bView commit details -
Initial docs and
cs_to_mutation_count
functionEdited `regex` matching to handle custom `cs` '<clip#>' ops.
1Configuration menu - View commit details
-
Copy full SHA for 74760e2 - Browse repository at this point
Copy the full SHA 74760e2View commit details -
Removed custom '<clipN>'
cs
notation.Instead of writing a script to process the '<clipN>' notation, I decided to stick with just using tuples to designate features that have clipping. This makes counting mutations and clipping easier.
1Configuration menu - View commit details
-
Copy full SHA for dcdb543 - Browse repository at this point
Copy the full SHA dcdb543View commit details -
Targets.parse_alignment_cs
cs, clip separate colReturn columns suffixes `_cs`, `_clip5`, and `_clip3` in `Targets.parse_alignment_cs`.
Configuration menu - View commit details
-
Copy full SHA for e994bb2 - Browse repository at this point
Copy the full SHA e994bb2View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for af99af1 - Browse repository at this point
Copy the full SHA af99af1View commit details -
Merge branch 'parse_alignment' of https://github.com/jbloomlab/alignp…
…arse into parse_alignment
Configuration menu - View commit details
-
Copy full SHA for 7c35ceb - Browse repository at this point
Copy the full SHA 7c35cebView commit details -
parse_alignment_cs
only gets features in specsPreviously `Targets.parse_alignment_cs` parsed **all** features; now it only parses the ones in `feature_parse_specs`.
Configuration menu - View commit details
-
Copy full SHA for 3c3caf9 - Browse repository at this point
Copy the full SHA 3c3caf9View commit details -
parse_alignment_cs
does not return target clipPreviously the `feature_parse_specs` and the returns from `parse_alignment_cs` included `target_clip5` and `target_clip3`. However, this is redundant with the feature- level clipping information, and so has been removed. The query clipping is retained as that is not redundant with feature-level clipping.
Configuration menu - View commit details
-
Copy full SHA for c480df0 - Browse repository at this point
Copy the full SHA c480df0View commit details -
Finished
cs_to____
functions for parsing cs str.Still need to add more rigorous tests.
Configuration menu - View commit details
-
Copy full SHA for 5c54039 - Browse repository at this point
Copy the full SHA 5c54039View commit details -
Configuration menu - View commit details
-
Copy full SHA for 786614f - Browse repository at this point
Copy the full SHA 786614fView commit details -
Merge branch 'parse_alignment' of https://github.com/jbloomlab/alignp…
…arse into parse_alignment
Configuration menu - View commit details
-
Copy full SHA for 6c7c2fe - Browse repository at this point
Copy the full SHA 6c7c2feView commit details
Commits on Aug 23, 2019
-
update to new
pandas
andplotnine
There are new vesions of `pandas` (0.25.1) and `plotnine` (0.6.0). Use those, and also update notebooks to have output from these; in particular the new `pandas` no longer shows the index in bold in data frames displayed in Jupyter notebooks.
Configuration menu - View commit details
-
Copy full SHA for 44ab13c - Browse repository at this point
Copy the full SHA 44ab13cView commit details -
tweak functions to get mutations from
cs
tagsOnly major change is that mutations from ambiguous are **not** counted as mutations in mutation strings. Otherwise just streamline code.
2Configuration menu - View commit details
-
Copy full SHA for 4ac5e49 - Browse repository at this point
Copy the full SHA 4ac5e49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 434c164 - Browse repository at this point
Copy the full SHA 434c164View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbf7fd8 - Browse repository at this point
Copy the full SHA fbf7fd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa03b38 - Browse repository at this point
Copy the full SHA aa03b38View commit details -
Initial filtering on feature clipping.
Likely has bugs, but general outline is there.
Configuration menu - View commit details
-
Copy full SHA for 8a3797d - Browse repository at this point
Copy the full SHA 8a3797dView commit details
Commits on Aug 24, 2019
-
Fixed some formatting, reverted making `Targets.parse_alignment_cs` private; it's now public method again. We can re-visit whether to make it public later.
Configuration menu - View commit details
-
Copy full SHA for 6ed3cf1 - Browse repository at this point
Copy the full SHA 6ed3cf1View commit details -
Simplify the initialization of `Targets` by modularizing operations like filling the defaults of `feature_parse_specs` and getting the names of features to parse in their own methods. Also, eliminated some redundant parameter checks that were confusing to read in the code.
Configuration menu - View commit details
-
Copy full SHA for a6a5790 - Browse repository at this point
Copy the full SHA a6a5790View commit details
Commits on Aug 25, 2019
-
Updates to `feature_parse_specs` input to `Targets`, and docs for `parse_alignments`. Specifically: - `parse_alignments` has different return described and can write CSV. - Previously there was a single `clip_count` in `feature_parse_specs`; now it is `clip5` and `clip3` separately. Example notebooks updated to reflect this.
Configuration menu - View commit details
-
Copy full SHA for 70fa968 - Browse repository at this point
Copy the full SHA 70fa968View commit details -
implement
multi_align
in alignment parsingPreviously, the `multi_align` option to `Targets.parse_alignment_cs` was ignored and secondary alignments were not filtered.
Configuration menu - View commit details
-
Copy full SHA for fc49dde - Browse repository at this point
Copy the full SHA fc49ddeView commit details -
The new `Targets.parse_alignment` is fully implemented except for the `Targets._parse_single_Alignment` method it utilizes. No testing yet.
Configuration menu - View commit details
-
Copy full SHA for f41b670 - Browse repository at this point
Copy the full SHA f41b670View commit details -
fully implemented
Targets.parse_alignment
The new `Targets.parse_alignments` is fully implemented and tested against `Targets._parse_alignments_csv` and for consistency in writing CSVs versus returning data frames. It still needs more testing for correctness of output and illustrative example. Also, added a parameter to `Targets` explicitly permittting the return of mutations / sequences of features with clipping; otherwise this is disallowed as it can give confusing results.
Configuration menu - View commit details
-
Copy full SHA for 837fcc5 - Browse repository at this point
Copy the full SHA 837fcc5View commit details
Commits on Aug 26, 2019
-
minor code / doc cleanup and update test
In addition to minor doc tweaks and slight code cleaning, implemented testing of `Targets.parse_alignment` in `test_Targets_parse_alignment.ipynb`.
Configuration menu - View commit details
-
Copy full SHA for 682f837 - Browse repository at this point
Copy the full SHA 682f837View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d2bd92 - Browse repository at this point
Copy the full SHA 1d2bd92View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6a4f87 - Browse repository at this point
Copy the full SHA b6a4f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for cee13bf - Browse repository at this point
Copy the full SHA cee13bfView commit details