Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reconcile): support cleared_* on parent accounts #38

Merged
merged 1 commit into from Oct 17, 2019

Conversation

jktomer
Copy link
Contributor

@jktomer jktomer commented Oct 17, 2019

Previously, due to an off-by-one error, an account's immediate parent's
cleared_dates would not be considered, though a higher ancestor's would.

Previously, due to an off-by-one error, an account's immediate parent's
cleared_dates would not be considered, though a higher ancestor's would.
@coveralls
Copy link

coveralls commented Oct 17, 2019

Pull Request Test Coverage Report for Build 110

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 27 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 66.418%

Files with Coverage Reduction New Missed Lines %
beancount_import/journal_editor.py 5 87.32%
beancount_import/reconcile.py 10 70.79%
beancount_import/webserver.py 12 33.8%
Totals Coverage Status
Change from base Build 109: 0.2%
Covered Lines: 13248
Relevant Lines: 19383

💛 - Coveralls

@jbms jbms merged commit 00e29e6 into jbms:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants