Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero unitprice #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Zero unitprice #55

wants to merge 2 commits into from

Conversation

stin7
Copy link

@stin7 stin7 commented Apr 11, 2020

Workaround for Issue #54

@stin7 stin7 mentioned this pull request Apr 11, 2020
Open
@coveralls
Copy link

coveralls commented Apr 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 122

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-66.8%) to 0.0%
Totals Coverage Status
Change from base Build 116: -66.8%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@jbms
Copy link
Owner

jbms commented Jul 24, 2020

Thanks for this fix. It looks like this addresses a similar issue to #47 (see the discussion in particular). Since I believe UNITPRICE is required according to the OFX spec (though I may be misreading it), it probably makes sense to calculate it if it is missing or inaccurate, but to include a warning via txn.meta['ofx_error'] = '...' to notify the user.

@Zburatorul Zburatorul mentioned this pull request Mar 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stin7 @coveralls @jbms