Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultipro_google: support additional deduction section formats #7

Merged
merged 1 commit into from Jan 26, 2019

Conversation

jktomer
Copy link
Contributor

@jktomer jktomer commented Jan 25, 2019

Some of my Google pay statements have a slightly different format for the deductions section than the ones supported here; they include both Based-On and Pre-Tax (yes/no) columns.

Also I happen to have exactly one pay statement with an empty document ID; included a small patch so that such a document doesn't cause an exception.

@coveralls
Copy link

coveralls commented Jan 25, 2019

Pull Request Test Coverage Report for Build 34

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 63.42%

Changes Missing Coverage Covered Lines Changed/Added Lines %
beancount_import/source/ultipro_google_statement.py 0 5 0.0%
Totals Coverage Status
Change from base Build 33: -0.05%
Covered Lines: 4022
Relevant Lines: 6219

💛 - Coveralls

@jbms jbms merged commit e271551 into jbms:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants