Rendering of :kbd: role is a bit off

[ruslo]

Here is how :kbd: rendered in a light theme:

It seems that the top of the object is missing.

It's slightly better with a dark theme:

Same code for the read-the-docs theme:

Live samples:

• https://read-the-docs-template-cdkwuttv.readthedocs.io/en/v1.0.0/highlight_text.html
• https://read-the-docs-template-cdkwuttv.readthedocs.io/en/v0.0.1/highlight_text.html

[2bndy5]

Can you supply the RST code to reproduce?

It looks like the undesired offset happens when there's nested <kbd> elements.

<kbd>
  <kbd>Ctrl</kbd>
  +
  <kbd>F</kbd>
</kbd>

Have you also looked into the keys role? The keys role's CSS is exclusive to this theme because the CSS is inherited from mkdocs-material theme...

[ruslo]

Can you supply the RST code to reproduce?

See: highlight_text.rst

Have you also looked into the keys role?

Okay, it helped with the nested case 👍 But the top of the object is still not distinct:

Compare with:

[2bndy5]

CSS for the keys role is inherited from mkdocs-material source: src/assets/stylesheets/main/extensions/pymdownx/_keys.scss.

We also don't use any CSS from sphinx basic theme: sphinx/themes/basic/static/basic.css_t. But I don't see any CSS rules specific to kbd elements there.

Lastly, the RTD sphinx theme adds its own CSS specific to kbd elements: See their src/sass/_theme_rst.sass file.

So, to solve this we would need to add some CSS for kbd elements that are generated by the :kbd: role and be careful to not alter the rules defined for the :keys: role.

Just my opinion

I have some reservations about making any CSS changes because this theme is meant to be a port of the mkdocs-material theme to sphinx, not a material-design adaptation of the RTD sphinx theme... Looking at how the kbd elements are styled in upstream mkdocs-material, I feel like the current style is expected behavior.

There's also nothing stopping users from adding their own CSS to a project via sphinx, but having the different :keys: and :kbd: roles may complicate that idea too much for some doc authors.

[2bndy5]

There also seems to be slight differences in how different browsers render the kbd elements. In Firefox, the offset looks fine, but Chrome seems to position the kbd elements' contents a bit higher than Firefox.

[ruslo]

I have some reservations about making any CSS changes because this theme is meant to be a port of the mkdocs-material theme to sphinx, not a material-design adaptation of the RTD sphinx theme... Looking at how the kbd elements are styled in upstream mkdocs-material, I feel like the current style is expected behavior

Okay, I see, indeed the issue is the same there.

In Firefox, the offset looks fine, but Chrome seems to position the kbd elements' contents a bit higher than Firefox

For me, Firefox looks similar:

[2bndy5]

I think the upstream artistic style can still be preserved while adding the requested visual distinction by simply darkening the kbd elements' background-color for light mode only:

[data-md-color-scheme="default"] kbd {
  background-color: #dfdfdf;
}

which results in

The background-color for kbd elements and the main body element is practically the same color in light mode.

---

EDIT: I also noticed that the pymdown.keys docs also override the background-color to use #ebebeb instead of the mkdocs-material's default #fafafa.

pymdown.keys	mkdocs-material

[ruslo]

I think the upstream artistic style can still be preserved while adding the requested visual distinction by simply darkening the kbd elements' background-color for light mode only

Look good:

• https://read-the-docs-template-cdkwuttv.readthedocs.io/en/v1.0.2/highlight_text.html

Code: ruslo/read_the_docs_template@6951d7a

Thank you!