allow user-interactive color changes in customization doc #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
reviewed
May 7, 2023
2bndy5
force-pushed
the
live-color-customization
branch
2 times, most recently
from
75c1f57
to
06963ef
Compare
I revised the list of color schemes, primary and accent options , so users can click on the "badge" (actually a styled inline literal) to test the supported values. The corresponding example code-block's content is also adjusted accordingly.
blah
2bndy5
force-pushed
the
live-color-customization
branch
from
06963ef
to
45991e0
Compare
jbms
reviewed
May 9, 2023
jbms
reviewed
May 9, 2023
2bndy5
force-pushed
the
live-color-customization
branch
from
1c9ff4a
to
fe487be
Compare
2bndy5
added a commit
that referenced
this pull request
May 15, 2023
This a follow up to #256 that orders the colors as they are listed in the CSS bundle (according to hue). The original ordering was a bit chaotic because it was grabbing the color names from rules specifically for hyperlink elements. But, by only grabbing the color names from rules that define the fg/bg color vars, we get the originally expected results.
2bndy5
added a commit
that referenced
this pull request
May 18, 2023
This a follow up to #256 that orders the colors as they are listed in the CSS bundle (according to hue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revised the list of color
scheme,primaryandaccentoptions, so users can click on the "badge" (actually a styled inline literal) to dynamically test the supported values. The corresponding example code-block's content is also dynamically adjusted accordingly. Similar to upstream's doc, the color changes do not persist after page (re)load.