Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correct the issue with the client not communicating the
mimeType
to the server.What the PR covers:
WebSocketGremlinConnection
now sends messages asbinary
andmasked
GremlinClient
now packs the request messages in binary with the includedmimeType
headersGremlinClient
now unpacks the binary Blob response sent back from the serverI wasn't able to get
npm run test:node
to work, got some strange legacy node error ; I think my env isn't setup correctly. So this will need testing as I only have some manual testing going for this PR at the moment.FYI, my manual testing covers:
application/json
simple send and reading response (haven't tried any streaming)application/gremlinbin
same as above