Allow user to close the connection #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, on my phone right now - I will review tomorrow.
…On Fri, 14 Jul 2017 at 14:33, Brian ***@***.***> wrote:
I run this in an AWS lambda environment and need the ability to end the
connection. It's appears to be missing so I have added it to
WebSocketGremlinConnection.js.
------------------------------
You can view, comment on, or merge this pull request online at:
#81
Commit Summary
- Add ability to terminate connection
- Add ability to terminate connection
- Delete .DS_Store
File Changes
- *M* src/WebSocketGremlinConnection.js
<https://github.com/jbmusso/gremlin-javascript/pull/81/files#diff-0>
(4)
Patch Links:
- https://github.com/jbmusso/gremlin-javascript/pull/81.patch
- https://github.com/jbmusso/gremlin-javascript/pull/81.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#81>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAMa1AyapXX_Bjsc65t02c2TdRXW6iWYks5sN2AFgaJpZM4OYMsv>
.
|
|
Hey @jbmusso . Any chance of merging this and releasing a new npm version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run this in an AWS lambda environment and need the ability to end the connection. It's appears to be missing so I have added it to WebSocketGremlinConnection.js.