Skip to content

Commit

Permalink
Performance optimizations (ca. Factor 75)
Browse files Browse the repository at this point in the history
- Precomputed style function
- Skip arguments to array + join if there's only one argument (the
  common case)
- Merge multiple return statements to one

To calculate the performance benefit:

```javascript
var chalk = require('./index.js');
console.time('100000 iterations');
for (var i = 0; i < 100000; i++) {
	chalk.red('A string that is about 80 characters long (normal use I think?)');
}
console.timeEnd('100000 iterations');
```

Running this before this commit:
```shell
for i in {1..5}; do node time.js; done
100000 iterations: 19485ms
100000 iterations: 18933ms
100000 iterations: 19365ms
100000 iterations: 19332ms
100000 iterations: 18660ms
```

After:
```shell
100000 iterations: 268ms
100000 iterations: 261ms
100000 iterations: 264ms
100000 iterations: 259ms
100000 iterations: 254ms
```

Performance gain, taking the middle result of both:
```shell
19332 / 261 = 74.~
```

Closes chalk#16
  • Loading branch information
Joshua Appelman committed Jun 25, 2014
1 parent eff96c2 commit af909be
Showing 1 changed file with 23 additions and 20 deletions.
43 changes: 23 additions & 20 deletions index.js
Expand Up @@ -25,32 +25,35 @@ var styles = (function () {
return ret;
})();

function applyStyle() {
// support varags, but simply cast to string in case there's only one arg
var str = arguments.length === 1 ?
arguments[0] + '' :
[].slice.call(arguments).join(' ') ||
'';

if (!chalk.enabled || !str) {
return str;
}

return applyStyle._styles.reduce(function (str, name) {
var code = ansiStyles[name];
// Replace any instances already present with a re-opening code
// otherwise only the part of the string until said closing code
// will be colored, and the rest will simply be 'plain'.
return code.open + str.replace(code.closeRe, code.open) + code.close;
}, str) ;
};

function init() {
var ret = {};

Object.keys(styles).forEach(function (name) {
var style = defineProps(applyStyle, styles);
ret[name] = {
get: function () {
var obj = defineProps(function self() {
var str = [].slice.call(arguments).join(' ');

if (!chalk.enabled) {
return str;
}

return self._styles.reduce(function (str, name) {
var code = ansiStyles[name];
return str ? code.open +
// Replace any instances already present with a re-opening code
// otherwise only the part of the string until said closing code
// will be colored, and the rest will simply be 'plain'.
str.replace(code.closeRe, code.open) + code.close : '';
}, str);
}, styles);

obj._styles = [];

return obj[name];
style._styles = [];
return style[name];
}
};
});
Expand Down

0 comments on commit af909be

Please sign in to comment.