Set ActivitySource.Version to NuGet package version #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbogard, could you please review? Also 2 other opened PRs? |
jbogard
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: issue when it is hard to determine what is the instrumentation library version used in end-user project.
Previously this package was always reporting 1.0.0.0 (Assembly version).
MinVer is setting more user friendly value in
AssemblyInformationalVersionAttributeattribute in following format:1.7.2-alpha.0.39+69cc79aed00a37c103b9e46488e2001db959a1ab.Similar changes in otel-contrib repository: open-telemetry/opentelemetry-dotnet-contrib#1624
Results after changes:
