Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments in Cargo.toml being purged #194

Closed
nothingismagick opened this issue Apr 19, 2021 · 4 comments
Closed

comments in Cargo.toml being purged #194

nothingismagick opened this issue Apr 19, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@nothingismagick
Copy link

When running covector, it seems that comments in toml files are being pruned.

@jbolda jbolda added the bug Something isn't working label Apr 20, 2021
@jbolda
Copy link
Owner

jbolda commented Apr 20, 2021

This is an issue upstream in https://github.com/tauri-apps/tauri-toml. We should probably confirm that the fixes there have been addressed in the original https://github.com/iarna/iarna-toml and switch back to that if appropriate. (tauri-toml was forked to add support for inline objects which Rust/cargo allows as an option when specifying a dependency version.)

/cc @lucasfernog, have you looked into it?

@jbolda
Copy link
Owner

jbolda commented Apr 10, 2022

Considering if we can address this via #236.

@amrbashir
Copy link
Collaborator

Just checked iarna-toml and unfortunately this has not been resolved upstream yet iarna/iarna-toml#42.

I think we shouldn't wait for upstream and instead build a NAPI module using napi-rs that delegates the work to toml-edit crate which preserves the comments. I can help setting this up if approved.

@jbolda
Copy link
Owner

jbolda commented Jun 6, 2024

Closed by #303 and published in #300.

@jbolda jbolda closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants