Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom node property with index of rows #282

Merged
merged 2 commits into from
May 28, 2021
Merged

Add custom node property with index of rows #282

merged 2 commits into from
May 28, 2021

Conversation

mabhub
Copy link
Contributor

@mabhub mabhub commented Feb 5, 2021 •
edited
Loading

This allows the use of rowIndex node property for sorting GraphQL query results (no matter the node creation order), and so preserving UI order of Airtable tables when a view is set in plugin config.

Testable using npm install mabhub/gatsby-source-airtable#2.1.1-mkc0

@bernharduw bernharduw mentioned this pull request Mar 15, 2021
Closed
@bernharduw
Copy link

This works perfectly! I also published this publicly to NPM as @bernhardg/gatsby-source-airtable because I had issues about the examples folder when using the npm command as above.

Install via npm install --save @bernhardg/gatsby-source-airtable or yarn add @bernhardg/gatsby-source-airtable until this is merged to main.

bernharduw
bernharduw approved these changes Mar 31, 2021
View reviewed changes
Copy link

@bernharduw bernharduw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@jbolda
Copy link
Owner

jbolda commented May 24, 2021 •
edited
Loading

Hey, thanks for tackling this! Life has been incredibly hectic and free time is a very high premium. Helpfully Travis CI decided to quit on us, so I needed to put up all of the infrastructure again.

If you wouldn't mind rebasing, adding a change file, and docs, we can look at getting this out the door. Thanks!

@mabhub
Copy link
Contributor Author

mabhub commented May 26, 2021 •
edited
Loading

If you wouldn't mind rebasing, adding a change file, and docs, we can look at getting this out the door. Thanks!

I hope finding time to do this before the end of the week!

jbolda
jbolda approved these changes May 28, 2021
View reviewed changes
Copy link
Owner

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ready for merging @mabhub?

@mabhub
Copy link
Contributor Author

mabhub commented May 28, 2021

Ready for merging @mabhub?

Sure! let's go!

@jbolda
Copy link
Owner

jbolda commented May 28, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented May 28, 2021

Build succeeded:

@bors bors bot merged commit a8ca899 into jbolda:main May 28, 2021
@jbolda
Copy link
Owner

jbolda commented Jul 2, 2021

@all-contributors please add @mabhub for code and docs

@allcontributors allcontributors bot mentioned this pull request Jul 2, 2021
Merged
@allcontributors
Copy link
Contributor

@jbolda

I've put up a pull request to add @mabhub! 🎉

bors bot added a commit that referenced this pull request Jul 2, 2021
@bors @allcontributors @jbolda
Merge #338 #339
edebdcf 
338: docs: add mabhub as a contributor for code, doc r=jbolda a=allcontributors[bot]

Add @mabhub as a contributor for code, doc.

This was requested by jbolda [in this comment](#282 (comment))

339: delete stale.yml r=jbolda a=jbolda

Let's remove the stale bot. We seem to just be fighting it.

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Jacob Bolda <me@jacobbolda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernharduw bernharduw bernharduw approved these changes

@jbolda jbolda jbolda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mabhub @bernharduw @jbolda