Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation doesn't work on Submit #17

Closed
leolorenzoluis opened this issue May 13, 2016 · 5 comments
Closed

Validation doesn't work on Submit #17

leolorenzoluis opened this issue May 13, 2016 · 5 comments

Comments

@leolorenzoluis
Copy link

leolorenzoluis commented May 13, 2016

Using

<so-checkbox-group params="val: Changes"></so-checkbox-group>

It doesn't validate the check boxes.

@leolorenzoluis leolorenzoluis changed the title Validation doesn't work on Save Validation doesn't work on Submit May 13, 2016
@jbonfardeci
Copy link
Owner

Why do you think that is? It's explained in the doc and is intentional.
On May 13, 2016 11:07 AM, "leolorenzoluis" notifications@github.com wrote:

Validation only works when you click Submit, but on Save it creates the
item and bypasses validation.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#17

@leolorenzoluis
Copy link
Author

The documentation says on save. I understand Save won't balidate but Submit should?

@leolorenzoluis
Copy link
Author

'if (isSubmit && !self.formIsValid(vm)) {
return;
}'

It does validate on other fields but not this so template? Could you show me which documentation you're referring to?

@jbonfardeci
Copy link
Owner

Validation occurs on Submit but not Save. This allows users to fill out long forms and save their work in progress. In our organization, sometimes an exec will have a form open the whole day as they deal with interruptions constantly.

If using this workflow, you must add a step in your SharePoint workflow that waits until IsSubmitted (boolean Yes/No) is equal to true; then the remaining workflow steps occur.

For Knockout components, you must set the option required: true. For other non-knockout components, add there required attribute to the element.

On May 15, 2016, at 5:36 PM, leolorenzoluis notifications@github.com wrote:

The documentation says on save. I understand Save won't balidate but Submit should?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub #17 (comment)

@leolorenzoluis
Copy link
Author

Right, I guess GitHub didn't update my Title. I originally had it as Validation not occuring on Save, but I changed it to Validation not occuring on Submit. When I click submit, it validates on other fields like so-text-field but not so-checkbox-group even adding required attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants