Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment markers being stripped when building python wheels #15

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Fix environment markers being stripped when building python wheels #15

merged 1 commit into from
Oct 15, 2017

Conversation

jobec
Copy link
Contributor

@jobec jobec commented Aug 21, 2017

Fixes #14

@coveralls
Copy link

coveralls commented Aug 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.925% when pulling 2256d5f on jobec:master into 2c5021c on jborean93:master.

@jobec
Copy link
Contributor Author

jobec commented Sep 14, 2017

Any chance at merging this?

@jborean93
Copy link
Owner

Hey @jobec, I'm currently a bit busy right now and don't have time to look at this until maybe 2 weeks time.

I had played around with this because of #6 but IIRC there was an issue with extras_requires but I can't remember what it was. It is weird as I remember ordereddict not being installed on the newer versions but obviously something has happened since I had it working.

@jborean93
Copy link
Owner

Thanks @jobec, sorry for taking so long to get to this. I've tested it and it works perfectly.

@jborean93 jborean93 merged commit f36aeb7 into jborean93:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jobec @coveralls @jborean93