Fix bug when clearing NTLMSSP_NEGOTIATE_OEM flag #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to not modify any other negotiate flags when clearing NTLMSSP_NEGOTIATE_OEM in server response. Previous code could cause various problems depending on which negotiate flags that were set in the server response, e.g. wrongly clearing NTLMSSP_NEGOTIATE_SIGN resulted in the session key not being set.
|
No idea why 1 Python version failed on Appveyor, have rerun the job and it works fine. Thanks for picking up on this issue and creating a PR. |
|
Thanks for merging this. When do you plan to make a new release? |
|
Hopefully by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to not modify any other negotiate flags when clearing
NTLMSSP_NEGOTIATE_OEM in server response.
Previous code could cause various problems depending on which negotiate
flags that were set in the server response, e.g. wrongly clearing
NTLMSSP_NEGOTIATE_SIGN resulted in the session key not being set.