Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gathering requests and responses for tests with a flag. #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samathy
Copy link

@Samathy Samathy commented Oct 20, 2020

I used the fake transport from tests/conftest in my own test code, and needed a reasonable way to enable/disable the gathering of requests and responses for building tests that didn't involve finding and editing wsman.py on my test machine.

@Samathy Samathy force-pushed the enable-test-messages-flag branch 2 times, most recently from ed68aa1 to d85004a Compare October 20, 2020 11:00
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #92 into master will decrease coverage by 0.08%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   98.41%   98.32%   -0.09%     
==========================================
  Files          12       12              
  Lines        3284     3292       +8     
==========================================
+ Hits         3232     3237       +5     
- Misses         52       55       +3     
Impacted Files Coverage Δ
pypsrp/wsman.py 97.45% <62.50%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8a41a...75a6ee1. Read the comment docs.

@jborean93
Copy link
Owner

Unfortunately this isn't something I want to expose publicly as doing so would mean the setup is always there. Maybe there's a better way for your test harness to use the code. You could use monkeypatch to hook into one of the send methods to get the value but I'm not sure if that will work with what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants