Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUD-2597] User AMQ_REPLICAS AND VOLUME_CAPACITY in the templates #17

Merged
merged 1 commit into from
Jun 5, 2018
Merged

[CLOUD-2597] User AMQ_REPLICAS AND VOLUME_CAPACITY in the templates #17

merged 1 commit into from
Jun 5, 2018

Conversation

vbusch
Copy link
Contributor

@vbusch vbusch commented Jun 1, 2018

  • amq-broker-71-statefulset-clustered.yaml needed to use AMQ_REPLICAS
  • all 4 stateful templates needed to use the VOLUME_CAPACITY variable

Signed-off-by: Vanessa Busch vbusch@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@vbusch
[CLOUD-2597] User AMQ_REPLICAS AND VOLUME_CAPACITY in the templates
fd489bb 
- amq-broker-71-statefulset-clustered.yaml needed to use AMQ_REPLICAS
- all 4 stateful templates needed to use the VOLUME_CAPACITY variable

Signed-off-by: Vanessa Busch <vbusch@redhat.com>
dsimansk
dsimansk approved these changes Jun 5, 2018
View reviewed changes
Copy link

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@vbusch vbusch merged commit 7874ab5 into jboss-container-images:amq-broker-71-dev Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbusch @dsimansk