Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDG-5257] Add group to openshift API. #231

Conversation

rigazilla
Copy link
Collaborator

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Ungrouped API are deprecated on OCP since 4.7
https://issues.redhat.com/browse/JDG-5257

@yselkowitz
Copy link

There is one template which still uses apps/v1beta1 instead of apps/v1 for StatefulSet, but otherwise LGTM.

Signed-off-by: Vittorio Rigamonti <vrigamon@redhat.com>
@rigazilla
Copy link
Collaborator Author

There is one template which still uses apps/v1beta1 instead of apps/v1 for StatefulSet, but otherwise LGTM.

fixed, thanks!

@ryanemerson ryanemerson merged commit 999bef8 into jboss-container-images:datagrid73-dev May 24, 2022
@ryanemerson
Copy link
Collaborator

Thanks @rigazilla

@yselkowitz
Copy link

This needs to also land in the datagrid73 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants