Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUD-2203 Incorrect Role Mapper environment variable name in yaml file #71

Merged
merged 1 commit into from Aug 2, 2018
Merged

CLOUD-2203 Incorrect Role Mapper environment variable name in yaml file #71

merged 1 commit into from Aug 2, 2018

Conversation

ryanemerson
Copy link
Collaborator

@ryanemerson ryanemerson requested a review from osnipso July 31, 2018 12:20
@galderz
Copy link
Contributor

galderz commented Aug 1, 2018

Looks good too. What about testing this somehow?

osnipso
osnipso approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@osnipso osnipso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR should correspond to a verification build attached to CLOUD-2203, but since we're in the releasing phase for the sprint 21 image, it will be verified by QE before releasing.

@osnipso osnipso merged commit fb72b5f into jboss-container-images:datagrid72-dev Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osnipso osnipso osnipso approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@ryanemerson @galderz @osnipso