Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12 #46

Merged
merged 1 commit into from
Jul 18, 2019
Merged

[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12 #46

merged 1 commit into from
Jul 18, 2019

Conversation

spolti
Copy link
Member

@spolti spolti commented Jul 18, 2019

Signed-off-by: Filippe Spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject or [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti
[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12
60e7dc5 
Signed-off-by: Filippe Spolti <fspolti@redhat.com>
@errantepiphany errantepiphany added 6.4.x ⇨ 6.4.12 6.4.x branch work for version 6.4.12 release ready 🚀 work completed and ready to be merged labels Jul 18, 2019
errantepiphany
errantepiphany reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spolti Just wondering about the empty lines.

templates/docs/decisionserver64-amq-s2i.adoc

|`${APPLICATION_NAME}` | decisionserver-keystore-volume | `/etc/decisionserver-secret-volume` | ssl certs | True
|=============


=== External Dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all the empty lines added?

templates/docs/decisionserver64-basic-s2i.adoc
@@ -194,3 +194,7 @@ for more information.


=== External Dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

templates/docs/decisionserver64-https-s2i.adoc

|`${APPLICATION_NAME}` | decisionserver-keystore-volume | `/etc/decisionserver-secret-volume` | ssl certs | True
|=============


=== External Dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@errantepiphany errantepiphany self-requested a review July 18, 2019 17:06
@errantepiphany errantepiphany merged commit dda57ce into jboss-container-images:6.4.x Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errantepiphany errantepiphany errantepiphany approved these changes

Assignees
No one assigned
Labels
6.4.x ⇨ 6.4.12 6.4.x branch work for version 6.4.12 release ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@spolti @errantepiphany