Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-3377 build fixes for CPaaS #56

Merged
merged 1 commit into from Oct 23, 2019

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Oct 22, 2019

https://issues.jboss.org/browse/CLOUD-3377
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

- name: jboss-eap-modules
git:
url: https://github.com/jboss-container-images/jboss-eap-modules
ref: 6.4.22-2
ref: 6.4.22-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you will create tag "6.4.22-3" when PR jboss-container-images/jboss-eap-modules#140 is merged, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just incremented it and will do it once this gets in.

Copy link
Member

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luck3y luck3y merged commit 9f4adf7 into jboss-container-images:6.4.x Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants