Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUD-2993 - Move base layer of EAP 7.1 image from jboss-openjdk to rhel7 #113

Merged
merged 2 commits into from Jan 3, 2019
Merged

CLOUD-2993 - Move base layer of EAP 7.1 image from jboss-openjdk to rhel7 #113

merged 2 commits into from Jan 3, 2019

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Dec 7, 2018

https://issues.jboss.org/browse/CLOUD-2993
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request contains description of the issue
  • Pull Request does not include fixes for other issues
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

rcernich
rcernich previously approved these changes Dec 7, 2018
View reviewed changes
luck3y
luck3y commented Dec 7, 2018
View reviewed changes
modules/install-cleanup/install.sh Outdated
@@ -48,10 +48,6 @@ function aggregate_patched_modules {
fi

rm -rf /tmp/standalone

if [ -n "$sys_pkgs" ]; then
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bstansberry After testing, this does not appear to be still needed. I'm not 100% clear on what changed to allow it to work though...

@luck3y
Copy link
Collaborator Author

luck3y commented Dec 7, 2018

@rcernich Sorry I had one last change to push, so it dismissed your approval :(

@luck3y luck3y merged commit 74b5a27 into jboss-container-images:eap71-dev Jan 3, 2019
@luck3y luck3y deleted the CLOUD-2993 branch April 10, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcernich rcernich rcernich approved these changes

@apintea apintea Awaiting requested review from apintea

@bstansberry bstansberry Awaiting requested review from bstansberry

Assignees
No one assigned
Labels
approved dev-approved qe-approved
Milestone
No milestone
2 participants
@luck3y @rcernich