Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUD-3421 - 7.2.4 install module is missing cekit version field #164

Merged
merged 1 commit into from
Nov 8, 2019
Merged

CLOUD-3421 - 7.2.4 install module is missing cekit version field #164

merged 1 commit into from
Nov 8, 2019

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Nov 6, 2019

https://issues.jboss.org/browse/CLOUD-3421
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request contains description of the issue
  • Pull Request does not include fixes for other issues
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

rgdoliveira
rgdoliveira reviewed Nov 7, 2019
View reviewed changes
modules/7.2.4/module.yaml
@@ -1,6 +1,7 @@
schema_version: 1

name: "eap-7.2.4"
version: "1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this change be in file modules/7.2.5/module.yaml ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in both of them, this PR was created before the 7.2.5 module PR was created.

Copy link
Contributor

@dbkreling dbkreling Nov 8, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a separate PR to merge this to 7.2.5/module.yaml [0] and will merge both.

[0] #166

dbkreling
dbkreling approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@dbkreling dbkreling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #166 adds the change to the file in the 7.2.5 version. This one looks good to me.

@dbkreling dbkreling merged commit d6910ea into jboss-container-images:7.2.x Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgdoliveira rgdoliveira rgdoliveira left review comments

@jmesnil jmesnil jmesnil approved these changes

@dbkreling dbkreling dbkreling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@luck3y @jmesnil @dbkreling @rgdoliveira