Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUD-3860] Initial version of XP 2.0 image #209

Merged
merged 2 commits into from Dec 8, 2020

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Dec 1, 2020

https://issues.redhat.com/browse/CLOUD-3860
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request contains description of the issue
  • Pull Request does not include fixes for other issues
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@luck3y
Copy link
Collaborator Author

luck3y commented Dec 1, 2020

Note this should be held until we have final artifacts.

@luck3y luck3y added the hold label Dec 1, 2020
dbkreling
dbkreling previously approved these changes Dec 1, 2020
Copy link
Contributor

@dbkreling dbkreling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jfdenise
jfdenise previously approved these changes Dec 1, 2020
description: "Environment variable used to specify the debug port. If not set, the default EAP debug port will be used (8787). Only applicable when development mode is enabled."
envs:
- name: "WILDFLY_VERSION"
value: "7.3.4.GA-redhat-00003"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbkreling , yes 2.0.0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

Copy link
Contributor

@dbkreling dbkreling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: the final artifacts were promoted and can be found at http://download.devel.redhat.com/devel/candidates/middleware/eap-xp/JBEAPXP-2.0.0-GA-CR1/

@luck3y luck3y dismissed stale reviews from jfdenise and dbkreling via 078a987 December 8, 2020 15:43
@luck3y luck3y removed the hold label Dec 8, 2020
@luck3y luck3y merged commit 8216558 into jboss-container-images:eap73-dev Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants