Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD- update EAP 7.1 build config for 7.1.6 #204

Merged

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Feb 6, 2019

https://issues.jboss.org/browse/CLOUD-3090
Signed-off-by: Ken Wills kwills@redhat.com
Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

url: https://github.com/jboss-container-images/jboss-eap-7-image.git
ref: eap71-dev
url: https://github.com/jboss-container-images/jboss-eap-7-image.git
ref: eap71-dev

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spacing change would be rejected in other cases, but as you're the maintainer, that's fine :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually this is correcting WS, so I'm ok with leaving it.

Copy link

@apintea apintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I'm totally not an expert at this, but the logic for the updates seems reasonable. Thank you!

@bstansberry bstansberry merged commit ee34ec1 into jboss-container-images:eap71-dev Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants